refactor!: use same paths representation for unix/windows #390
Conversation
aawsome
force-pushed
the
typed_path
branch
2 times, most recently
from
dbc9dab to
32ae757
Compare
aawsome
changed the title
aawsome
force-pushed
the
typed_path
branch
2 times, most recently
from
a9d526f to
af6ae1c
Compare
aawsome
force-pushed
the
typed_path
branch
3 times, most recently
from
6731779 to
626d588
Compare
aawsome
changed the title
|
I manually rebased to newest main. |
| }; | ||
| let node = Node::new_node(&p, NodeType::Dir, meta); | ||
| return Some(TreeType::NewTree((self.path.clone(), node, p))); | ||
| if let Some(p) = missing_dirs.components().next() { |
There was a problem hiding this comment.
Why remove the for loop?
Both typed_path::UnixPathBuf::components and std::path::PathBuf::components seem "normalize" the same way their output (methods have identical documentation) which makes me wonder why it's ok to remove the loop.
PS: after seeing the now deleted comp_to_osstr, I am starting to think, that the typed_path::UnixPathBuf::components output might be "much" simpler than std.., is it related to that?
| #[case(r#"d:\"#, "/d")] | ||
| #[case(r#"a\b\"#, "a/b")] | ||
| #[case(r#"a\b\c"#, "a/b/c")] | ||
| fn test_windows_path_to_unix_path(#[case] windows_path: &str, #[case] unix_path: &str) { |
There was a problem hiding this comment.
I believe more testing could be good for these methods, for instance: are conversion methods reversible? foo == windows_to_unix(unix_to_windows(foo))?
There was a problem hiding this comment.
What do you thing about renaming this file, could be something like path_util.
I propose that because there are only path related utils methods.
There was a problem hiding this comment.
Honestly, all these conversions could be error prone. I don't feel confident in my review for this part.
|
waiting for BurntSushi/ripgrep@79f5a5a to be released in |
Use typed_path to use a common unix path representation on both windows/unix. This will increase windows compatibility and makes testing easier.
PR in rustic to integrate this change: rustic-rs/rustic#1466