Skip to content

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Oct 4, 2024

No description provided.

@simonsan simonsan added A-testing Area: Testing and coverage C-bug Category: Something isn't working as expected A-commands Area: Related to commands in `rustic_core` labels Oct 4, 2024
@simonsan simonsan marked this pull request as draft October 4, 2024 00:57
Signed-off-by: simonsan <[email protected]>
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.0%. Comparing base (e84373e) to head (cff8aa7).

Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/repository/command_input.rs 65.9% <ø> (ø)

... and 4 files with indirect coverage changes

// consistent with the other platforms.
#[allow(clippy::unnecessary_wraps)]
#[cfg(windows)]
fn split(s: &str) -> RusticResult<Vec<String>> {
Copy link
Member

@aawsome aawsome Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this, this is a change and not only a PR about tests;-)

I experimented shortly on winsplit. One drawback I found was that it seems to be impossible to have the reverse operation of split - this makes a suitable Display impl quite hard.

Also I just wanted to note that a OS-dependent parsing may cause irritation for users using both windows and non-windows. I don't use windows, but are there cases where shellwords::split don't work on windows commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm playing around with it to get a feeling for the parsing. It's true, that we need to be attentive here.

@aawsome
Copy link
Member

aawsome commented Oct 4, 2024

just one thing: Did you see the tests in crates/core/tests/command_input.rs?

@simonsan
Copy link
Contributor Author

simonsan commented Oct 4, 2024

just one thing: Did you see the tests in crates/core/tests/command_input.rs?

Thanks for the heads-up, no I didn't, I was actually wondering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-commands Area: Related to commands in `rustic_core` A-testing Area: Testing and coverage C-bug Category: Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants