Skip to content

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Mar 4, 2024

BREAKING CHANGE: Moves json to global options.

TODO:

@aawsome aawsome changed the title WIP: feat(commands): Add json output option to prune WIP: feat(commands)!: Add json output option to prune Mar 4, 2024
@simonsan simonsan added C-enhancement Category: New feature or request M-breaking Meta: Breaking change A-commands Area: Related to commands in `rustic` labels Oct 2, 2024
@simonsan
Copy link
Contributor

simonsan commented Oct 2, 2024

rustic_core#173 has been merged, this needs conflicts to be resolved still. Anything else to add?

@aawsome
Copy link
Member Author

aawsome commented Oct 11, 2024

rustic_core#173 has been merged, this needs conflicts to be resolved still. Anything else to add?

I think we should first thing of which information we want to display in the json output before we just serialize stats.debug. I mean, yes, it could be the information we want to present, but also something else may be wanted...

@aawsome
Copy link
Member Author

aawsome commented Oct 11, 2024

Besides this, we should not mix making --json a global attribute with a json output of prune, IMO...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-commands Area: Related to commands in `rustic` C-enhancement Category: New feature or request M-breaking Meta: Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants