Skip to content

fix: remove redundant function call when delete replication config#119

Open
LeonWang0735 wants to merge 1 commit into
rustfs:mainfrom
LeonWang0735:remove-redundant-function-call-when-delete-replication-config
Open

fix: remove redundant function call when delete replication config#119
LeonWang0735 wants to merge 1 commit into
rustfs:mainfrom
LeonWang0735:remove-redundant-function-call-when-delete-replication-config

Conversation

@LeonWang0735
Copy link
Copy Markdown
Contributor

Pull Request

Description

When deleting the last replication rule, the first API call (DeleteBucketReplication) already removes the ReplicationTarget on the backend.

The frontend then made a second delete call (remove-remote-target) for the same target, which could return an error.
Although the replication config was actually deleted successfully, this error message could mislead users into thinking the delete operation failed, and users had to refresh to see the correct state.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

@overtrue overtrue changed the title fix:remove redundant function call when delete replication config fix: remove redundant function call when delete replication config May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant