Repository navigation
fix(watch): order repeated event filters for SigV4 verification - #399
Merged
Merged
Conversation
Signed-off-by: overtrue <anzhengchao@gmail.com>
houseme
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #392.
The default
put,delete,getfilters are sent as repeatedeventsquery parameters in that order. The AWS signer sorts encoded values, while RustFS's verifier preserves their wire order. The resulting canonical-query mismatch causes SignatureDoesNotMatch even with valid credentials.Sort the encoded event values before building the URL. This keeps every requested filter and aligns both bucket and root watch requests with the signed order. Add a regression for the three default events at both scopes.
Validation: the new regression fails on main. An independent HTTP/SigV4 probe also reproduces exit code 4 before the fix; afterward it validates the signature and receives an object event, then deliberately interrupts the stream.
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspacepass with Rust 1.99.0 (1,954 passed; 2 existing ignored tests).