Repository navigation
fix(admin): use the realtime metrics route - #398
Merged
Merged
Conversation
Signed-off-by: overtrue <anzhengchao@gmail.com>
houseme
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #388.
rc admin metricssends requests to/rustfs/admin/v3/metrics, while RustFS serves realtime metrics at/rustfs/admin/v3/realtime. The wrong route produces a misleading NotImplemented response, including on the default command with no grouping flags.Use
/realtimeand update the route assertions for the default command and the encoded filter/grouping query. Correct the internal response-type documentation as well.Validation: the route regression failed before the fix.
cargo fmt --all --check,cargo clippy --workspace -- -D warnings,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspacepass with Rust 1.99.0 (1,953 passed; 2 existing ignored tests).