-
Notifications
You must be signed in to change notification settings - Fork 8
feat(admin): add expansion workflow command #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| //! Expansion workflow commands for post-expansion data rebalancing. | ||
|
|
||
| use clap::Subcommand; | ||
|
|
||
| use super::rebalance; | ||
| use crate::exit_code::ExitCode; | ||
| use crate::output::Formatter; | ||
|
|
||
| const EXPAND_AFTER_HELP: &str = "\ | ||
| Examples: | ||
| rc admin expand start local | ||
| rc admin expand status local | ||
| rc admin expand stop local | ||
|
|
||
| Notes: | ||
| Add server pools by updating the RustFS service configuration and restarting | ||
| the deployment first. This command manages the post-expansion rebalance step."; | ||
|
|
||
| /// Expansion workflow subcommands | ||
| #[derive(Subcommand, Debug)] | ||
| #[command(after_help = EXPAND_AFTER_HELP)] | ||
| pub enum ExpandCommands { | ||
| /// Start post-expansion data rebalancing | ||
| Start(rebalance::StartArgs), | ||
|
|
||
| /// Show post-expansion rebalance status | ||
| Status(rebalance::StatusArgs), | ||
|
|
||
| /// Stop a running post-expansion rebalance | ||
| Stop(rebalance::StopArgs), | ||
| } | ||
|
|
||
| /// Execute an expansion workflow subcommand | ||
| pub async fn execute(cmd: ExpandCommands, formatter: &Formatter) -> ExitCode { | ||
| match cmd { | ||
| ExpandCommands::Start(args) => { | ||
| rebalance::execute_start_with_messages( | ||
| args, | ||
| formatter, | ||
| "Expansion rebalance started successfully", | ||
| "Failed to start expansion rebalance", | ||
| ) | ||
| .await | ||
| } | ||
| ExpandCommands::Status(args) => rebalance::execute_status(args, formatter).await, | ||
| ExpandCommands::Stop(args) => { | ||
| rebalance::execute_stop_with_messages( | ||
| args, | ||
| formatter, | ||
| "Expansion rebalance stopped successfully", | ||
| "Failed to stop expansion rebalance", | ||
| ) | ||
| .await | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the public
rc admin expandcommand changes the CLI contract, butdocs/SPEC.mdstill only documentsadmin rebalanceand has noadmin expandsyntax, alias, JSON-output references, or exit-code section. SinceAGENTS.mdidentifiesdocs/SPEC.mdas the CLI behavior contract and the PR checklist requires contract changes to be documented, users and any spec-based validation will miss this new workflow even though it is now exposed in help and README.Useful? React with 👍 / 👎.