CI: Only run cargo check for MSRV
#296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
madsmtm/msrv-ci
branch
2 times, most recently
from
ad207fd to
ea80ded
Compare
madsmtm
changed the title
cargo check for MSRVcargo check for MSRV
madsmtm
force-pushed
the
madsmtm/msrv-ci
branch
6 times, most recently
from
31dd4ed to
8264ef9
Compare
Member
The main goal is to make sure we at least check our minimum version bounds in CI. It was only last weekend that a crate was depending on |
madsmtm
force-pushed
the
madsmtm/msrv-ci
branch
2 times, most recently
from
3679f50 to
0ecab92
Compare
It should be enough to verify that the code compiles, we're testing it elsewhere, and we don't need development dependencies to follow MSRV.
madsmtm
force-pushed
the
madsmtm/msrv-ci
branch
from
0ecab92 to
8abac8d
Compare
Member
Author
|
I've merged #260 and rebased this op top of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be enough to verify that the code compiles, we're testing it elsewhere, and we don't need development dependencies to follow MSRV.
Semi alternative to #260 (since after this, I suspect we're gonna run into much fewer problems with MSRV breaking CI).