This repository was archived by the owner on Nov 6, 2024. It is now read-only.
Switch to rust-vmm-ci #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreeaflorescu
force-pushed
the
rust_vmm_ci
branch
2 times, most recently
from
e9905ee to
4e5171b
Compare
alxiord
reviewed
Jan 3, 2020
Use Buildkite and rust-vmm-ci for testing. Signed-off-by: Andreea Florescu <[email protected]>
Import bindings from x86::bindings so we don't need to have the same logic to exclude features twice (once in the x86/mod.rs and once in x86/fam_wrappers.rs). Signed-off-by: Andreea Florescu <[email protected]>
andreeaflorescu
force-pushed
the
rust_vmm_ci
branch
from
4e5171b to
18391d2
Compare
andreeaflorescu
force-pushed
the
rust_vmm_ci
branch
from
18391d2 to
30a2e59
Compare
When the crate is built with --all-features we have a bunch of errors because we are not excluding the 4.14 and 4.20 bindings. Whenever all features is specified now, the 4.20 bindings are going to be used. This change is required for switching to rust-vmm-ci where the tests are run using --all-features flag. Signed-off-by: Andreea Florescu <[email protected]>
Autogenerated code throws lots of clippy errors. Disable the warnings as we don't want to manually edit autogenerated code. Signed-off-by: Andreea Florescu <[email protected]>
The linker was unable to find __addtf3, __multf3 and __subtf3. Added target-feature=+crt-static and link-arg=-lgcc as a temporary workaround. This seems to be the accepted fix in the Rust community: rust-lang/compiler-builtins#201 A permanent fix is yet to be implemented in the Rust compiler. Signed-off-by: Andreea Florescu <[email protected]>
andreeaflorescu
force-pushed
the
rust_vmm_ci
branch
from
30a2e59 to
abc9368
Compare
alxiord
approved these changes
Jan 6, 2020
sameo
approved these changes
Jan 7, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Buildkite and rust-vmm-ci for testing.
For a successful build, a few other changes were required:
cargo test --all-featuresas a step.