-
Notifications
You must be signed in to change notification settings - Fork 384
Hosting mdbook with gh-pages #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
548e0ea
to
0e09f5b
Compare
simonsan
commented
Jan 1, 2021
simonsan
commented
Jan 1, 2021
simonsan
commented
Jan 1, 2021
simonsan
commented
Jan 1, 2021
simonsan
commented
Jan 1, 2021
simonsan
commented
Jan 1, 2021
Adding instructions on how to build the book in the readme or in contribution guidelines might be nice.
|
Added ;-) |
marcoieni
reviewed
Jan 1, 2021
Looks good to me. |
Closed
marcoieni
approved these changes
Jan 1, 2021
simonsan
added a commit
that referenced
this pull request
Jan 1, 2021
simonsan
added a commit
that referenced
this pull request
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-addition
Category: Adding new content, something that didn't exist in the repository before
S-review
Status: A PR that is currently under review or where a review is the next step
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
book.toml
configuration file and some (still empty)Readme.md
files to the categories.Output can be followed here
Filling the descriptions of the categories I think would make sense to make in another PR, due to possible discussions about the content. For now I think just adding this should be fine. Thoughts/feedback?
Regarding the domain:
Renaming this repository to 'rust-patterns'
on the discussion board: #113supersedes #53
fixes #6