Skip to content

Fix no-std alloc builds #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sicking
Copy link
Contributor

@sicking sicking commented Jul 12, 2018

Currently --no-default-features --features=alloc builds from master are failing which makes all PRs fail tests.

@sicking
Copy link
Contributor Author

sicking commented Jul 12, 2018

I'm not sure what's going on. But this doesn't seem like the right fix.

@sicking sicking closed this Jul 12, 2018
@sicking sicking deleted the fixalloc branch July 12, 2018 13:03
@dhardy
Copy link
Member

dhardy commented Jul 12, 2018

Ah, I can tell you what's going on!

Recent versions of nightly Rust re-organised the (still unstable) alloc crate. This caused CI failures which I fixed in #545.

You obviously still have an older nightly compiler, hence the fixes break your local builds.

It really is a pain having unstable dependencies (and they could probably have handled it better by introducing deprecations under the old names, as aliases to the new names), but oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants