Skip to content

Update changelog #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2018
Merged

Update changelog #453

merged 2 commits into from
May 18, 2018

Conversation

pitdicker
Copy link
Contributor

No description provided.

Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good. I was meaning to get to this; thanks for getting there first!

@@ -35,7 +35,7 @@

#![doc(html_logo_url = "https://www.rust-lang.org/logos/rust-logo-128x128-blk.png",
html_favicon_url = "https://www.rust-lang.org/favicon.ico",
html_root_url = "https://docs.rs/rand_core/0.1.0")]
html_root_url = "https://docs.rs/rand_core/0.2")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mentioned in the top-level Cargo.toml but not the rand_core one...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md Outdated
- Add `Range::sample_single` to allow for optimized implementations. (#274)
- Rename `Range` to `Uniform`. (#)
- Add `Uniform::new_inclusive` for inclusive ranges. (#274)
- Add `Uniform::sample_single` to allow for optimized implementations. (#274)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has been removed in #454

CHANGELOG.md Outdated
- Rework `Range` type, making it possible to implement it for user types. (#274)
- Add `Range::new_inclusive` for inclusive ranges. (#274)
- Add `Range::sample_single` to allow for optimized implementations. (#274)
- Rename `Range` to `Uniform`. (#)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pitdicker
Copy link
Contributor Author

Updated. Thanks for looking carefully, I messed some things up. I mentioned #435 in the line about adding a prelude, it seemed to me the module organisation is not that visible to users.

@dhardy dhardy merged commit 9019132 into rust-random:master May 18, 2018
@pitdicker pitdicker deleted the changelog_05 branch May 18, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants