Implement std::io::Read for RngCore #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sdleffler |
|
It's fine afaik but I've forgotten any concerns from before. |
dhardy
approved these changes
May 8, 2018
|
I don't worry too much about our error codes not mapping nicely to IO errors. Seems like a common problem for all library-specific errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We once played with the idea of having an implementation of
std::io::ReadforRng#254, and that it could live in thereadmodule #366 (comment).I don't think it needs a wrapper type, as we can simply implement it for
RngCore. Then the natural place would be inrand_core, so no need to preserve thereadmodule.This is not a very exiting PR in my opinion, I just wanted to test if it was necessary to keep the
readmodule around. Just as well make a PR then.