Remove Sized constraint for generic Rng
#175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for greater use of Rng as a trait object. This is especially the case when one wants to do T::rand(rng) and 'rng' is some &mut Rng.
|
Think I already addressed this in my PR #161 (PR still needs a lot of work in general though). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface: This is a breaking change!!
Recently I tried using
Randon aRngtrait object but I was unable to sinceRand::randrequires that theRngbeSized.This is mostly a proof-of-concept that should be considered when going through with the next iteration of this project.
Limitations:
chooseare implemented generically onRng. These cannot be used within the context of a trait object.if rng.gen() { ... }whenRngis notSized#[derive(Rand)]implementationgenandgen_range