Use postcard instead of bincode in tests #1693
Merged
+23
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
This PR switches from using
bincodetopostcardas the intermediate encoding for the serde roundtrip tests.Motivation
Someone in contact with the bincode maintainers has mentioned that it's not really maintained anymore and recommended the ecosystem switch away from it:
I don't think it's particularly important that we stop using bincode here for any technical reasons; rather, it's because
randis a very popular reverse dependency of bincode, and probably contributes to its popularity. If popular crates switch to something else, we can hopefully reduce the number of people who reach for bincode simply due to its popularity.Details
For the
rand_pcgtests, I've removed the boilerplace withBufReader/BufWriterand switched to serializing to aVecand deserializing from it. This is partly because postcard doesn't have theirstd::iointerface quite worked out yet. Everything else is a fairly straightforward port.