[breaking change] Automatically impl Sample for T: IndependentSample #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to manually implement Sample for types that implement IndependentSample, cutting down on boilerplate and reducing chances for mis-matched implementations. It also adds blanket impls for `&T` where `T: IndependentSample`, so that `.sample()` can be called on these types without needing a unique reference. This is a breaking change because it conflicts with crates that impl both Sample and IndependentSample for their own types.
|
This may not be worth doing if one (or both) of these traits is ultimately going away, ala #27. |
|
Indeed, we're aiming for something closer to #27, though not exactly (I have an incomplete implementation here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to manually implement Sample for types that implement IndependentSample, cutting down on boilerplate and reducing chances for mis-matched implementations.
It also adds blanket impls for
&TwhereT: IndependentSample, so that.sample()can be called on these types without needing a unique reference.This is a breaking change because it conflicts with crates that implement both Sample and IndependentSample for their own types.