Skip to content

Fix Redox CI #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2019
Merged

Fix Redox CI #85

merged 2 commits into from
Aug 25, 2019

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Aug 13, 2019

Fixes #79

@newpavlov
Copy link
Member

Hopefully rust-lang/rust#63521 will land soon and we will not have to use xbuild for Redox.

@newpavlov
Copy link
Member

@josephlr
Can you revert to the old cargo build? The builder PR has landed, so we should get pre-built Redox std soon.

@josephlr
Copy link
Member Author

@newpavlov will do. Looks like redox is now back to building in the latest nightly.
https://rust-lang.github.io/rustup-components-history/x86_64-unknown-redox.html

@newpavlov
Copy link
Member

Argh, looks like libc is still broken on Redox...

@josephlr
Copy link
Member Author

Argh, looks like libc is still broken on Redox...

I confirmed locally that 0.2.62 seems to fix things. So this can be merged once the CI passes.

@josephlr josephlr merged commit 4db1b14 into rust-random:master Aug 25, 2019
@josephlr josephlr deleted the redox branch August 25, 2019 02:23
@josephlr
Copy link
Member Author

Whoops @newpavlov, I thought you had approved this, so I merged it. We should probably enable the feature that requires review before merging. Would that work for you?

@newpavlov
Copy link
Member

Yeah, no problem. I am not sure if we need this setting, but either way, I think we will need @dhardy for that.

@dhardy
Copy link
Member

dhardy commented Aug 25, 2019

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redox support
3 participants