update Step::steps_between to latest rust nightly version #518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the signature change in rust-lang/rust#130867
I also used this opportunity to change the backing implementation to use
u64
instead ofusize
. That way functions likesteps_between
is always working forPage
even on 32bit architectures. The old implementation would returnNone
even if the step count is knowable forPages
but not forVirtAddr
.I wasn't sure whether I should create this PR against master or next. While this is a breaking change it is a breaking change in a nightly feature, where breaking changes are expected. If you want I can easily rebase this on next.