Skip to content

update Step::steps_between to latest rust nightly version #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Wasabi375
Copy link
Contributor

This implements the signature change in rust-lang/rust#130867

I also used this opportunity to change the backing implementation to use u64 instead of usize. That way functions like steps_between is always working for Page even on 32bit architectures. The old implementation would return None even if the step count is knowable for Pages but not for VirtAddr.

I wasn't sure whether I should create this PR against master or next. While this is a breaking change it is a breaking change in a nightly feature, where breaking changes are expected. If you want I can easily rebase this on next.

@Wasabi375 Wasabi375 closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant