Implement the ConnectController/DisconnectController methods #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
requested changes
Dec 4, 2021
|
Didn't want to let my minor nits stand in the way of this change, so I went ahead and rebased and fixed those up. Also added the new methods to the changelog since we have that now :) Thanks for the PR! |
|
Oh wow nice, thanks, I kind of moved on from uefi+rust in the past time and forgot about those PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll have to fix this if/when #309 gets merged :)doneIf've tested this directly locally in my own project (getting the pointers with like
((bs as *const _ + 1) as *const usize - 14) as *const fn ptr), have not figured out how to actually run/write the tests from this crate so I'll later add some tests here.