uefi: SNP transmit: document parameters #1664
Conversation
| /// | ||
| /// The packet structure depends on the type of network interface, but | ||
| /// effectively this is always a (wired) ethernet interface. In these cases, | ||
| /// this function transmits ethernet frames. |
There was a problem hiding this comment.
Is there some citation we can point to for this paragraph? In particular, is true that it's always wired? (I wouldn't be terribly surprised if some enterprising motherboard manufacturers supported wifi netboot, for example.)
There was a problem hiding this comment.
From my understanding, WiFis packet structure makes effective use incompatible with the SNP interface.
Therefore, we have EFI_WIRELESS_MAC_CONNECTION_PROTOCOL. Would you prefer it if I rephrase it as "in most cases, this refers to an Ethernet interface"?
There was a problem hiding this comment.
Ah, I didn't know that a wifi interface would be incompatible. "in most cases, this refers to an Ethernet interface" sounds good to me
| /// - `src_addr`: The optional source address. | ||
| /// - `dst_addr`: The optional destination address. | ||
| /// - `protocol`: Ether Type as of RFC 3232. See | ||
| /// <https://www.iana.org/assignments/ieee-802-numbers/ieee-802-numbers.xhtml#ieee-802-numbers-1> |
There was a problem hiding this comment.
nit: For nicer rendering, how about changing to a named link like See [IANA IEEE 802 Numbers][ethertype] for examples.
Split-out from #1621
Checklist