Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Since Rust 1.77,
round_ties_even
was added tof32
andf64
in the standard library. This function is used within WGPU, and as a part of a push forno_std
support, this function will need to be shimmed. It could be shimmed within Naga, but this functionality may have value to other users ofnum-traits
.Solution
round_ties_even
toFloatCore
with a default implementation (not a breaking change)msrv_1_77
, which allows overriding the default implementation ofFloatCore::round_ties_even
forf32
andf64
with the implementation fromstd
(not a breaking change)round_ties_even
matches the implementation instd
for thef32
type (assuming it is equally valid forf64
)Notes
msrv_1_77
feature increases MSRV to 1.77, which is a typical arrangement (e.g.,serde
features will typically elevate MSRV). If/whennum-traits
advances past MSRV 1.77, this feature can become a no-op without any breaking changes.num-traits
, please let me know if there's anything I can do to help!