Specify error types where possible #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't name a specific error type in `PrimitiveNumber: FromStr` because it's different between floats and ints. However, we **can** refine that in `PrimitiveFloat` and `PrimitiveInteger` to specify their respective error types. Similarly, `PrimitiveInteger: TryFrom<_>` is not specific because the error could be `Infallible` or `TryFromIntError`. In the cases of `PrimitiveSigned: TryFrom<i8>` and `PrimitiveUnsigned: TryFrom<u8>` though, we do know they are always `Infallible` -- which is implied by their respective `From`, but needs to be explicit.
cuviper
force-pushed
the
specify-errors
branch
from
933df54 to
2c324ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't name a specific error type in
PrimitiveNumber: FromStrbecause it's different between floats and ints. However, we can refine that inPrimitiveFloatandPrimitiveIntegerto specify their respective error types.Similarly,
PrimitiveInteger: TryFrom<_>is not specific because the error could beInfallibleorTryFromIntError. In the cases ofPrimitiveSigned: TryFrom<i8>andPrimitiveUnsigned: TryFrom<u8>though, we do know they are alwaysInfallible-- which is implied by their respectiveFrom, but needs to be explicit.