Add trait PrimitiveBytes for PrimitiveNumber::Bytes
#14
+144
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The direct constraints on `PrimitiveNumber::Bytes` did not render well in documentation, as everything was listed on one line. With a new trait this is more easily documented, and we can add new methods akin to the `core::array` constructors `from_fn` and `repeat`. This also adds `IndexMut<usize>` to the list of supertraits, as well as `PartialEq` and `TryFrom` for slice references.
cuviper
force-pushed
the
primitive-bytes
branch
from
580e4f7 to
01ce79c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direct constraints on
PrimitiveNumber::Bytesdid not render wellin documentation, as everything was listed on one line. With a new trait
this is more easily documented, and we can add new methods akin to the
core::arrayconstructorsfrom_fnandrepeat.This also adds
IndexMut<usize>to the list of supertraits, as well asPartialEqandTryFromfor slice references.