ip6tun: additional fixups #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvaclav-rh
force-pushed
the
ip6tun-flags
branch
from
978e8ec to
9e27cbe
Compare
cathay4t
requested changes
Nov 18, 2025
Member
cathay4t
left a comment
cathay4t
left a comment
There was a problem hiding this comment.
Please include unit test for this.
Contributor
Author
|
@cathay4t There are already existing unit tests for ipip/ipip6/ip6ip6/sit interface, which I modified for these changes. What should I test with the new unit test? |
cathay4t
approved these changes
Nov 25, 2025
Member
|
You are correct. Approved. |
Previously, the flags were represented as a raw u32, which is not practical. We should instead use the defined Ip6TunnelFlags for this purpose. Signed-off-by: Jan Vaclav <[email protected]>
Signed-off-by: Jan Vaclav <[email protected]>
Signed-off-by: Jan Vaclav <[email protected]>
Signed-off-by: Jan Vaclav <[email protected]>
cathay4t
force-pushed
the
ip6tun-flags
branch
from
7af0440 to
c822afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.