Skip to content

fix: add missing icmp6 stats #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add missing icmp6 stats #141

wants to merge 2 commits into from

Conversation

sabify
Copy link

@sabify sabify commented Jan 20, 2025

No description provided.

@cathay4t
Copy link
Member

@sabify Can you fix error in https://github.com/rust-netlink/netlink-packet-route/actions/runs/12863899553/job/35861354827?pr=141

Could you also include small comment in git commit helping me find correct lines in linux kernel code for this changes?

@cathay4t
Copy link
Member

Never mind the CI failure. Let me fix it now.

cathay4t
cathay4t requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is OutRateLimitGlobal before OutRateLimitHost.

@cathay4t
Copy link
Member

I have fixed the CI. Please rebase and fix the change request.

@cathay4t cathay4t added the Wait_Submitter PR reviewed with change requests label Jan 20, 2025
@sabify
Copy link
Author

sabify commented Jan 20, 2025

Here is the uapi link: https://github.com/torvalds/linux/blob/master/include/uapi/linux/snmp.h

@sabify sabify changed the title fix: add missing inet6 and icmp6 stats fix: add missing icmp6 stats Jan 20, 2025
@sabify
Copy link
Author

sabify commented Jan 20, 2025

By applying 201d99b commit, this PR only adds missing ICMPv6 stats.

@sabify
Copy link
Author

sabify commented Jan 20, 2025

There is OutRateLimitGlobal before OutRateLimitHost.

There isn't any OutRateLimitGlobal for ICMPv6 stats: https://github.com/torvalds/linux/blob/ffd294d346d185b70e28b1a28abe367bbfe53c04/include/uapi/linux/snmp.h#L118

@sabify sabify requested a review from cathay4t January 20, 2025 15:06
@sabify
Copy link
Author

sabify commented Mar 10, 2025

There is OutRateLimitGlobal before OutRateLimitHost.

There is no OutRateLimitGlobal in ICMPv6 and it is specific to ICMPv4 which is not implemented in this library.

The added OutRateLimitHost completes the set.

@sabify
Copy link
Author

sabify commented Mar 10, 2025

@cathay4t Would you mind review this PR?

@kanpov
Copy link

kanpov commented Mar 23, 2025

Hopefully, this fixes the Specified IFLA_INET6_ICMP6STATS NLA attribute holds more(most likely new kernel) data which is unknown to netlink-packet-route crate, expecting issue once it finally gets merged (@cathay4t ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathay4t cathay4t Awaiting requested review from cathay4t

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Wait_Submitter PR reviewed with change requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabify @cathay4t @kanpov