Fix status message parsing on different kernels #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status message has evolved, with fields being added in subsequent kernel versions. The parsing of this message excepts a recent version of it, making it fail to parse on older kernels. This is fixed by putting the newer fields behind an option. On parsing, those are set only if the received status payload is big enough.
This is a rather new field, seemingly present since the 5.9 kernel.
vthib
force-pushed
the
fix-status-message-different-kernels
branch
from
b64763a to
ac6e4ce
Compare
|
@cathay4t Can you take a look at the 3 PRs I submitted when you can? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this crate! I've been testing it in different environments and came upon an issue on older kernel versions. The StatusMessage has different length and fields depending on the kernel version, and it failed to parse correctly on centos7 for example, because of a received payload that was too short.
This PR does two things:
audit_statusstruct on a 2.6.32 (centos6):audit_statusstruct on a 6.4.3 (arch):