chore: remove leftover prints for tracing statements - Fixes TUI apps using the SDK #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when you get a chance, could you update your PR with the latest changes from the main branch? |
hashemix
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
I'm currently using this SDK for a TUI app, but the TUI breaks when the MCP server I'm trying to connect to fails either SSE or stdio, I noticed the eprint statements in the source code and I noticed that tracing was being used as well. Changing to tracing allows me to create a log file to redirect these errors and do not pollute the app with unexpected output.
🔍 Related Issues
✨ Changes Made
🛠️ Testing Steps
Create a new client and set-up an unreachable SSE server or stdio server, no output to stdout should be written unless rust_log is being set.
💡 Additional Notes