Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
When a
StdioTransport
is dropped, it's child process is meant to be killed along with it. However this does not work on Windows, allowing for zombie stdio processes to stay alive in the background.✨ Changes Made
Seems the code had separate sections for spawning in the child process on both Windows and Unix.
Fix was simple, instead of spawning a "cmd.exe" process and running the command on that:
Just run the command directly (as in the Unix case):
In practice, this just meant removing the Windows specific code, and using the Unix specific code for both.
🛠️ Testing Steps
Try running a stdio mcp server that does not terminate upon the server closing (e.g. if it's a Typescript server add a setInterval). The Rust program will hang because of the zombie process.
💡 Additional Notes
I imagine this bug is a result of development/testing happening on Unix rather than Windows. I am currently developing on Windows so I was able to catch it. Other than this bug, everything else seems to work perfectly. 👍