-
Notifications
You must be signed in to change notification settings - Fork 297
Stage 2: Embedded Cleanups #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@japaric, could you please (privately) send me the contact info for Aleksei Arbuzov/Terminal Technologies? I can only see a sales email for the company, and you might have a private contact. |
All items have been addressed. Re-requesting review from @aturon and @ashleygwilliams. |
@jamesmunns this looks good to me! Just a couple of adjustments:
Otherwise, I'm ready to merge this! |
Thanks for working on this @jamesmunns! It looks great.
👍 Right now if you directly land into this page and don't look at the URL it's not entirely clear at a first glance that this is about using Rust for embedded development. But if the pitch goes first then it's clearer that this about Rust for embedded development.
If that's the general trend then I'm OK with removing the "Friends" section. Semi on topic question about the "Production Use" section: Is it expected that this section will change or grow over time, or will it remain frozen after launch? If the former, has there been any discussion on the policy for adding entries to this section? (No need to block this PR on an answer to those questions). Other than those two points this looks good to me content-wise. I have one comment about font selection but I'll open a separate issue about that. |
In the interest of making progress, I've gone ahead and made the changes we discussed in a new commit. We can continue to iterate, of course. re: Production Use, I don't think it will be frozen, but part of the goal is to highlight the most interesting production cases, rather than trying to be comprehensive. We might consider having a separate location, perhaps the https://github.com/rust-lang/rust-marketing/ repo, for tracking a more exhaustive list of prod users over time. |
Thanks @aturon, this slipped off my radar. I would like to re-include at least Cambridge Consultants in the testimonials, as they provided a prepared statement. I'll open up a separate PR for that. |
In this PR I:
Particularly on item 8, please let me know if you would prefer the addition of Ferrous Systems to this page as a separate PR.
Before this can be merged, there are the following todo items:
For each of the following, obtain a job title, get a good logo, and vendor the logo in
static/images/user-logos
:I've also sent out the following messages, to try and get a final go/no-go for the following entities:
Also TODO:
Old screenshots:
Latest:
CC Issue #9