Skip to content

Stage 2: Embedded Cleanups #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 10, 2018
Merged

Stage 2: Embedded Cleanups #106

merged 15 commits into from
Oct 10, 2018

Conversation

jamesmunns
Copy link
Member

@jamesmunns jamesmunns commented Sep 30, 2018

In this PR I:

  1. Changed Project Gallery to "Showcase", as we do not have a gallery's worth of projects to showcase at the moment
  2. Replaced the Pollen Robotics video with a video recorded by JP for Cambridge Consultants.
  3. Minor grammatical and style changes
  4. Made "Community Driven" the 6th feature, and linked to the Embedded WG
  5. Added the two other testimonials, and made all testimonials "medium sized", instead of one liners
  6. Removed Otis from the list of friends/testimonials, as we have only received word from them privately, not publicly.
  7. Deduplicated the testimonials and friends of embedded rust sections
  8. Added Cambridge Consultants and Ferrous Systems to the friends section.

Particularly on item 8, please let me know if you would prefer the addition of Ferrous Systems to this page as a separate PR.

Before this can be merged, there are the following todo items:

For each of the following, obtain a job title, get a good logo, and vendor the logo in static/images/user-logos:

  • Sensirion, Raphael Nestler
  • Airborne Engineering Ltd., Adam Grieg
  • 49nord, Marc Brinkmann
  • Terminal Technologies, Aleksei Arbuzov
  • Cambridge Consultants, Jonathan Pallant

I've also sent out the following messages, to try and get a final go/no-go for the following entities:

  • Otis Elevators, Jeremy Mill
    • edit: Waiting for internal approval. I will open up a separate PR if they come back with a yes.

Also TODO:

  • Merge with PR STAGE 2: Embedded devices revisions #107
  • Update "feature" links to Book documentation, not Issues
    • edit: This is not ready. I have updated with current issue links
  • Add link to the bookshelf

Old screenshots:

Latest:

CC Issue #9

@jamesmunns
Copy link
Member Author

@japaric, could you please (privately) send me the contact info for Aleksei Arbuzov/Terminal Technologies?

I can only see a sales email for the company, and you might have a private contact.

@jamesmunns jamesmunns requested a review from aturon October 1, 2018 10:04
@jamesmunns jamesmunns changed the title Addressing outstanding embedded items Stage 2: Embedded Cleanups Oct 1, 2018
@jamesmunns
Copy link
Member Author

All items have been addressed. Re-requesting review from @aturon and @ashleygwilliams.

CC @japaric - some items were kicked to later. See #112.

@aturon
Copy link
Member

aturon commented Oct 3, 2018

@jamesmunns this looks good to me! Just a couple of adjustments:

  • In general, we're dropping the "Friends" sections and just keeping the "Production Use" section.
  • I'd recommend re-ordering the showcase below the pitch, but it's your call.

Otherwise, I'm ready to merge this!

@aturon aturon added this to the Content: Stage 2 milestone Oct 3, 2018
@japaric
Copy link
Member

japaric commented Oct 4, 2018

Thanks for working on this @jamesmunns! It looks great.

I'd recommend re-ordering the showcase below the pitch, but it's your call.

👍

Right now if you directly land into this page and don't look at the URL it's not entirely clear at a first glance that this is about using Rust for embedded development.

20181004-015952

But if the pitch goes first then it's clearer that this about Rust for embedded development.

20181004-020046

In general, we're dropping the "Friends" sections and just keeping the "Production Use" section.

If that's the general trend then I'm OK with removing the "Friends" section.

Semi on topic question about the "Production Use" section: Is it expected that this section will change or grow over time, or will it remain frozen after launch? If the former, has there been any discussion on the policy for adding entries to this section? (No need to block this PR on an answer to those questions).

Other than those two points this looks good to me content-wise. :shipit:

I have one comment about font selection but I'll open a separate issue about that.

@aturon
Copy link
Member

aturon commented Oct 10, 2018

In the interest of making progress, I've gone ahead and made the changes we discussed in a new commit. We can continue to iterate, of course.

re: Production Use, I don't think it will be frozen, but part of the goal is to highlight the most interesting production cases, rather than trying to be comprehensive. We might consider having a separate location, perhaps the https://github.com/rust-lang/rust-marketing/ repo, for tracking a more exhaustive list of prod users over time.

@aturon aturon merged commit 916a89c into master Oct 10, 2018
@jamesmunns
Copy link
Member Author

Thanks @aturon, this slipped off my radar. I would like to re-include at least Cambridge Consultants in the testimonials, as they provided a prepared statement. I'll open up a separate PR for that.

@ashleygwilliams ashleygwilliams deleted the embedded-2 branch October 29, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants