Fixes glacier command #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/handlers/glacier.rs
Outdated
|
|
||
| let url = cmd.source; | ||
| let response = ctx.github.raw().get(&format!("{}{}", url.replace("github", "githubusercontent"), "/playground.rs")).send().await?; | ||
| let response = ctx.github.raw().get(&format!("{}{}", url, "/raw")).send().await?; |
There was a problem hiding this comment.
Maybe it makes sense to just directly send a request to the relevant URL? That would give more flexibility and be easier to understand I think-- just saying "please provide a URL resolving to plain-text rust code" makes a lot of sense I think.
There was a problem hiding this comment.
Good idea, I'll change it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates octocrab to fix the issue mentioned in: rust-lang/glacier#231
Also, it fixes my mistake in parsing the URL. This also allows ANY gist to be used instead of just a playground link.