-
Notifications
You must be signed in to change notification settings - Fork 97
Add alias for compound labels #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6483af4
to
fd2c1cb
Compare
I think now it's ready for review. I've tested this patch on my test repository r? triagebot |
e08de03
to
167fdcb
Compare
r? @Urgau when you have time, thanks. (will rebase before merge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. Mainly some small nits.
7cf67bc
to
a38ad42
Compare
50c0ff1
to
31f0e2f
Compare
src/config.rs
Outdated
use parser::error::Error; | ||
use parser::token::Tokenizer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make the token
module public to access it in these tests. let me know if you don't agree with this change.
3da8091
to
8192865
Compare
@Urgau hopefully it should be ready to merge |
2b06b8a
to
c82efd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, modulo the unnecessary exposure of the parser internals.
Configure relabel command aliases from the `triagebot.toml`. When a valid alias is parsed, it will be replaced with the labels configured. Example configuration: ``` [relabel.cmd-alias] add-labels = ["Foo", "Bar"] rem-labels = ["Baz"] ``` The command `@rustbot label cmd-alias` translates to: ``` @rustbot label +Foo +Bar -Baz ``` The command `@rustbot label -cmd-alias` translates to: ``` @rustbot label +Baz -Foo -Bar ``` Note: self-canceling labels will be omitted. The command `@rustbot label cmd-alias +Baz` translates to: ``` @rustbot label +Foo +Bar ```
c82efd6
to
154a7e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Discussion on #triagebot > Generic shorcut handler @ 💬).
WIP,
currently blocked on a lifetime issueCloses #1634 and #2002