-
Notifications
You must be signed in to change notification settings - Fork 299
Workarounds for all/any mask reductions on x86, armv7, and aarch64 #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1d4668f
Work arounds for LLVM6 code-gen bugs in all/any reductions
gnzlbg f99000b
test avx on all x86 targets
gnzlbg 81641d6
disable assert_instr on avx test
gnzlbg 985893e
enable all appropriate features
gnzlbg 2d6cc25
disable assert_instr on x86+avx
gnzlbg a6bd57c
the fn_must_use is stable
gnzlbg 4462afb
fix nbody example on armv7
gnzlbg bd8e0e8
fixup
gnzlbg 17466e9
fixup
gnzlbg 8819741
enable 64-bit wide mask MMX optimizations on x86_64 only
gnzlbg 68f7719
remove coresimd dependency on cfg_if
gnzlbg 4ee0c5a
allow wasm to fail
gnzlbg fec0a3a
use an env variable to disable assert_instr tests
gnzlbg c589b1c
disable m32x2 mask MMX optimization on macos
gnzlbg a1390be
move cfg_if to coresimd/macros.rs
gnzlbg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'll somehow need to disable all the
assert_instr
tests as well as anything beneath avx is likely to generate different instructions with avx enabled