Skip to content

Intrinsic-test: Updated the Constraint enum to support discrete values #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions crates/intrinsic-test/src/common/constraint.rs
Original file line number Diff line number Diff line change
@@ -1,17 +1,24 @@
use serde::Deserialize;
use std::ops::Range;

/// Describes the values to test for a const generic parameter.
#[derive(Debug, PartialEq, Clone, Deserialize)]
pub enum Constraint {
/// Test a single value.
Equal(i64),
/// Test a range of values, e.g. `0..16`.
Range(Range<i64>),
/// Test discrete values, e.g. `vec![1, 2, 4, 8]`.
Set(Vec<i64>),
}

impl Constraint {
pub fn to_range(&self) -> Range<i64> {
/// Iterate over the values of this constraint.
pub fn iter<'a>(&'a self) -> impl Iterator<Item = i64> + 'a {
match self {
Constraint::Equal(eq) => *eq..*eq + 1,
Constraint::Range(range) => range.clone(),
Constraint::Equal(i) => std::slice::Iter::default().copied().chain(*i..*i + 1),
Constraint::Range(range) => std::slice::Iter::default().copied().chain(range.clone()),
Constraint::Set(items) => items.iter().copied().chain(std::ops::Range::default()),
}
}
}
2 changes: 1 addition & 1 deletion crates/intrinsic-test/src/common/gen_c.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pub fn generate_c_constraint_blocks<'a, T: IntrinsicTypeDefinition + 'a>(
};

let body_indentation = indentation.nested();
for i in current.constraint.iter().flat_map(|c| c.to_range()) {
for i in current.constraint.iter().flat_map(|c| c.iter()) {
let ty = current.ty.c_type();

writeln!(w, "{indentation}{{")?;
Expand Down
4 changes: 2 additions & 2 deletions crates/intrinsic-test/src/common/gen_rust.rs
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ pub fn generate_rust_test_loop<T: IntrinsicTypeDefinition>(

/// Generate the specializations (unique sequences of const-generic arguments) for this intrinsic.
fn generate_rust_specializations<'a>(
constraints: &mut impl Iterator<Item = std::ops::Range<i64>>,
constraints: &mut impl Iterator<Item = impl Iterator<Item = i64>>,
) -> Vec<Vec<u8>> {
let mut specializations = vec![vec![]];

Expand Down Expand Up @@ -292,7 +292,7 @@ pub fn create_rust_test_module<T: IntrinsicTypeDefinition>(
let specializations = generate_rust_specializations(
&mut arguments
.iter()
.filter_map(|i| i.constraint.as_ref().map(|v| v.to_range())),
.filter_map(|i| i.constraint.as_ref().map(|v| v.iter())),
);

generate_rust_test_loop(w, intrinsic, indentation, &specializations, PASSES)?;
Expand Down