[14elias]

Fixes #5144

Currently, rustup target add always pulls targets from the first installed channel toolchain alphabetically, ignoring any +toolchain override passed on the command line.

This causes a couple of issues:

• If you use a custom toolchain like rustup +stage1 target add , it still suggests targets even though custom toolchains don't have rustup-managed targets.
• If you specify a toolchain like +nightly, it might end up suggesting targets from another installed toolchain instead of nightly.

This changes fixes this by resolving the toolchain in this order:

1. Check if a +toolchain override was passed (if it's a custom toolchain, suggest nothing).
2. If not, check the active toolchain for the directory/default.
3. Fall back to the first installed toolchain if no active toolchain is set.

[rami3l]

Hello, thank you for the ping!

My apologies but I am disappointed with the quality of your work. The changes that you are making only scratch the surface of the problem and are done without further analysis of the codebase. If I keep accepting your patches without further cleanup I am afraid the quality of the outcome will not be ensured.

Please bear with me and allow me to take it from here.

View changes since this review

[14elias]

Hello, thank you for the ping!

My apologies but I am disappointed with the quality of your work. The changes that you are making only scratch the surface of the problem and are done without further analysis of the codebase. If I keep accepting your patches without further cleanup I am afraid the quality of the outcome will not be ensured.

Please bear with me and allow me to take it from here.

View changes since this review

Thank you for the honest feedback and i apologize for the disappointment i caused. please go ahead and take it from here i completely understand your wanting to ensure the quality. i will learn from the changes you make. i will do my best to improve the quality of my contribution going forward.

[rami3l]

@FranciscoTGouveia @14elias Patch updated via force push. Would you mind giving it another look?