Skip to content

Add proper testing for cases where divisions fail in iterators3 #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add proper testing for cases where divisions fail in iterators3 #2212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edcf19d
add proper testing for cases where divisions fail
lars-schumann Feb 24, 2025
b99e942
Update iterators3.rs
lars-schumann Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 50 additions & 10 deletions exercises/18_iterators/iterators3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ fn divide(a: i64, b: i64) -> Result<i64, DivisionError> {
}

// TODO: Add the correct return type and complete the function body.
// Desired output: `Ok([1, 11, 1426, 3])`
fn result_with_list() {
let numbers = [27, 297, 38502, 81];
let division_results = numbers.into_iter().map(|n| divide(n, 27));
// For numbers = [27, 297, 38502, 81] and divisor = 27,
// the desired output is: `Ok([1, 11, 1426, 3])`
fn result_with_list(numbers: Vec<i64>, divisor: i64) {
let division_results = numbers.into_iter().map(|n| divide(n, divisor));
}

// TODO: Add the correct return type and complete the function body.
// Desired output: `[Ok(1), Ok(11), Ok(1426), Ok(3)]`
fn list_of_results() {
let numbers = [27, 297, 38502, 81];
let division_results = numbers.into_iter().map(|n| divide(n, 27));
// For numbers = [27, 297, 38502, 81] and divisor = 27,
// the desired output is: `[Ok(1), Ok(11), Ok(1426), Ok(3)]`
fn list_of_results(numbers: Vec<i64>, divisor: i64) {
let division_results = numbers.into_iter().map(|n| divide(n, divisor));
}

fn main() {
Expand Down Expand Up @@ -63,11 +63,51 @@ mod tests {

#[test]
fn test_result_with_list() {
assert_eq!(result_with_list().unwrap(), [1, 11, 1426, 3]);
assert_eq!(
result_with_list(vec![27, 297, 38502, 81], 27),
Ok(vec![1, 11, 1426, 3])
);
assert_eq!(
result_with_list(vec![27, 297, 38502, 28], 27),
Err(DivisionError::NotDivisible)
);
assert_eq!(
result_with_list(vec![27, 297, 38502, 81], 0),
Err(DivisionError::DivideByZero)
);
assert_eq!(
result_with_list(vec![27, 297, i64::MIN, 81], -1),
Err(DivisionError::IntegerOverflow)
);
}

#[test]
fn test_list_of_results() {
assert_eq!(list_of_results(), [Ok(1), Ok(11), Ok(1426), Ok(3)]);
assert_eq!(
list_of_results(vec![27, 297, 38502, 81], 27),
vec![Ok(1), Ok(11), Ok(1426), Ok(3)]
);
assert_eq!(
list_of_results(vec![27, 297, 38502, 28], 27),
vec![Ok(1), Ok(11), Ok(1426), Err(DivisionError::NotDivisible)]
);
assert_eq!(
list_of_results(vec![27, 297, 38502, 81], 0),
vec![
Err(DivisionError::DivideByZero),
Err(DivisionError::DivideByZero),
Err(DivisionError::DivideByZero),
Err(DivisionError::DivideByZero)
]
);
assert_eq!(
list_of_results(vec![27, 297, i64::MIN, 81], -1),
vec![
Ok(-27),
Ok(-297),
Err(DivisionError::IntegerOverflow),
Ok(-81)
]
);
}
}
58 changes: 48 additions & 10 deletions solutions/18_iterators/iterators3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,17 @@ fn divide(a: i64, b: i64) -> Result<i64, DivisionError> {
Ok(a / b)
}

fn result_with_list() -> Result<Vec<i64>, DivisionError> {
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
let numbers = [27, 297, 38502, 81];
let division_results = numbers.into_iter().map(|n| divide(n, 27));
fn result_with_list(numbers: Vec<i64>, divisor: i64) -> Result<Vec<i64>, DivisionError> {
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
let division_results = numbers.into_iter().map(|n| divide(n, divisor));
// Collects to the expected return type. Returns the first error in the
// division results (if one exists).
division_results.collect()
}

fn list_of_results() -> Vec<Result<i64, DivisionError>> {
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
let numbers = [27, 297, 38502, 81];
let division_results = numbers.into_iter().map(|n| divide(n, 27));
fn list_of_results(numbers: Vec<i64>, divisor: i64) -> Vec<Result<i64, DivisionError>> {
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
let division_results = numbers.into_iter().map(|n| divide(n, divisor));
// Collects to the expected return type.
division_results.collect()
}
Expand Down Expand Up @@ -76,11 +74,51 @@ mod tests {

#[test]
fn test_result_with_list() {
assert_eq!(result_with_list().unwrap(), [1, 11, 1426, 3]);
assert_eq!(
result_with_list(vec![27, 297, 38502, 81], 27),
Ok(vec![1, 11, 1426, 3])
);
assert_eq!(
result_with_list(vec![27, 297, 38502, 28], 27),
Err(DivisionError::NotDivisible)
);
assert_eq!(
result_with_list(vec![27, 297, 38502, 28], 0),
Err(DivisionError::DivideByZero)
);
assert_eq!(
result_with_list(vec![27, 297, i64::MIN, 28], -1),
Err(DivisionError::IntegerOverflow)
);
}

#[test]
fn test_list_of_results() {
assert_eq!(list_of_results(), [Ok(1), Ok(11), Ok(1426), Ok(3)]);
assert_eq!(
list_of_results(vec![27, 297, 38502, 81], 27),
vec![Ok(1), Ok(11), Ok(1426), Ok(3)]
);
assert_eq!(
list_of_results(vec![27, 297, 38502, 28], 27),
vec![Ok(1), Ok(11), Ok(1426), Err(DivisionError::NotDivisible)]
);
assert_eq!(
list_of_results(vec![27, 297, 38502, 81], 0),
vec![
Err(DivisionError::DivideByZero),
Err(DivisionError::DivideByZero),
Err(DivisionError::DivideByZero),
Err(DivisionError::DivideByZero)
]
);
assert_eq!(
list_of_results(vec![27, 297, i64::MIN, 81], -1),
vec![
Ok(-27),
Ok(-297),
Err(DivisionError::IntegerOverflow),
Ok(-81)
]
);
}
}