Strip leading | in match arm patterns
#2804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue rust-lang#2621 This commit turns out to be a partial revert of ea3c01e The rationale is that a `|` character preceding a match pattern is not semantically relevant and therefore should be considered a style/formatting choice. A discussion concluded that the best way to emit consistent formatting here was to strip the leading `|` This removes the match_with_beginning_vert test because it was asserting the old behaviour which has been changed, it adds a new test (issue_2621) which should be a more comprehensive check of the behavior of `|` in match arms. Discussion at rust-lang/style-team#119
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #2621
This commit turns out to be a partial revert of
ea3c01e
The rationale is that a
|character preceding a match pattern is notsemantically relevant and therefore should be considered a
style/formatting choice.
A discussion concluded that the best way to emit consistent formatting
here was to strip the leading
|This removes the match_with_beginning_vert test because it was asserting
the old behaviour which has been changed, it adds a new test
(issue_2621) which should be a more comprehensive check of the behavior
of
|in match arms.Discussion at rust-lang/style-team#119