Replace allow attributes with expect and remove unused attributes
#797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
clean-up-allow
branch
from
d03d7df to
1548ba6
Compare
bjorn3
reviewed
Nov 5, 2025
| match arch { | ||
| "AMDGPU" => { | ||
| #[allow(non_snake_case)] | ||
| #[expect(non_snake_case)] |
Member
There was a problem hiding this comment.
This file is generated by generate_intrinsics.py, so next time it gets regenerated these changes will be overwritten.
Member
Author
There was a problem hiding this comment.
I should try to remember what the code I wrote is actually doing. ^^'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
expectinstead ofallowallows to know when an attribute is not triggered anymore, so that's quite useful considering it allowed me to remove quite a few of them here. :)