Reenable run-make tests #709
Merged
+80
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
force-pushed
the
reenable-run-make-tests
branch
3 times, most recently
from
59a5c76 to
e1a2cba
Compare
antoyo
force-pushed
the
reenable-run-make-tests
branch
from
e1a2cba to
033fa35
Compare
antoyo
force-pushed
the
reenable-run-make-tests
branch
from
64a28f0 to
906df38
Compare
antoyo
force-pushed
the
reenable-run-make-tests
branch
14 times, most recently
from
3769549 to
023240c
Compare
antoyo
force-pushed
the
reenable-run-make-tests
branch
from
023240c to
735a6d3
Compare
antoyo
commented
Jun 14, 2025
| .expected_file("short-error.txt") | ||
| .actual_text("(linker error)", out.stderr()) | ||
| - .normalize(r#"/rustc[^/]*/"#, "/rustc/") | ||
| + .normalize(r#"/tmp/rustc[^/]*/"#, "/tmp/rustc/") |
There was a problem hiding this comment.
@bjorn3: Since we both need this patch, do you know if there would be any way to have this change upstream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #538.