Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 6, 2026

This was causing 502 errors when non-default data was present in one of the examined commits.

Also turns the assertion into a user-visible error, to make this easier to debug.

@Kobzol
Copy link
Member Author

Kobzol commented Jan 6, 2026

(@lqd this was causing the 502 errors on the detailed page)

@lqd
Copy link
Member

lqd commented Jan 6, 2026

Does the link that used to fail work for you with this PR? (Can we even test this locally with the measureme files being on the server/S3?)

@Kobzol
Copy link
Member Author

Kobzol commented Jan 6, 2026

So, the previous link won't work (the link has to be different, so that we construct the DB query correctly). But this doesn't solve the whole issue - if you try to access a link for a Cranelift result, it will still either fail or return empty data. To fix that I'll have to refactor how we store self-profile data on S3 (will work on that as a follow-up).

This just fixes situations where the data is available, and you access the LLVM result, but there is also some associated Cranelift data.

@lqd
Copy link
Member

lqd commented Jan 6, 2026

Ok, and at least it won't pollute master commits from now on, as you also had; that's better either way than just crashing.

Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Kobzol Kobzol added this pull request to the merge queue Jan 6, 2026
Merged via the queue into rust-lang:master with commit 89db057 Jan 6, 2026
14 checks passed
@Kobzol Kobzol deleted the detailed-graphs-selector branch January 6, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants