Remove unused try benchmark request parameters #2362
Merged
+37
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Maybe do a github search for rust-timer comments? I've used this before, and I think I remember seeing one in the last few months -- but maybe it was just one of the profiles. It's not used a lot, that's for sure. |
Member
Author
|
Good point! The only slightly relevant mention I found is #1888 (comment) xD |
Mark-Simulacrum
approved these changes
Jan 6, 2026
Member
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
I used them once or twice ages ago but I think this makes sense (as you say, things are faster now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't ever seen anyone use runs, include or exclude on try build perf. runs, and the new system doesn't support them anyway. We now have better ways of selecting a subset of benchmarks I think, with targets, backends and profiles.