Skip to content

Rewrite/update compiler source code chapter #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 3, 2020
Merged

Rewrite/update compiler source code chapter #765

merged 10 commits into from
Aug 3, 2020

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Jun 24, 2020 •
edited
Loading

cc @crlf0710

close #817

@mark-i-m

This comment has been minimized.

Sign in to view
@mark-i-m
Copy link
Member Author

I think this is ready for review

jyn514
jyn514 reviewed Jul 11, 2020
View reviewed changes
@mark-i-m
Copy link
Member Author

I think this is ready for a final review

jyn514
jyn514 reviewed Jul 24, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick glance-over, I might review more thoroughly later.

src/compiler-src.md

The dependency structure is influenced strongly by two main factors:

1. Organization. The compiler is a _huge_ codebase; it would be an impossibly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity I ran tokei on it - 1.7 million lines of code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you exclude LLVM? That sounds a bit higher than I remember (~500K), but I might be wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was only counting lines of rust.

-------------------------------------------------------------------------------
 Language            Files        Lines         Code     Comments       Blanks
-------------------------------------------------------------------------------
 Alex                    4           85           67            0           18
 Assembly                3         1375          756          402          217
 GNU Style Assembly   6740      1516071       721657       473426       320988
 Autoconf              354        38316        22408        10153         5755
 Automake               12         6065         5149          162          754
 BASH                   10         1791         1387          226          178
 Batch                  18         1598         1342           50          206
 C                    6315       934950       529392       304222       101336
 C Header             7670      1448926       897283       335737       215906
 CMake                1196        59281        47496         5105         6680
 C#                      8          766          571          106           89
 C++                 20444      5295316      3766548       869578       659190
 C++ Header             29        11544         9675          809         1060
 CSS                    43         7378         6041          295         1042
 D                       1           18           16            0            2
 Dockerfile             89         2963         2174          308          481
 .NET Resource           2          269          132          113           24
 Emacs Lisp              9         1296          910          241          145
 FORTRAN Modern          8          398            0          371           27
 GDB Script              1           41           13           15           13
 Go                   1912       482175       362283        71149        48743
 Handlebars              4          138          116            7           15
 HEX                     1           15           15            0            0
 HTML                  186       462384       444556         4440        13388
 INI                     3           30           25            0            5
 JavaScript             55         8000         6409          886          705
 JSON                  144        10028        10028            0            0
 LLVM                23437      3668320      1477481      1865951       324888
 LD Script               1            4            4            0            0
 Lua                     1            7            5            0            2
 Makefile              804         6620         4481          697         1442
 Markdown             1936       171532       171532            0            0
 Module-Definition     118        25860        23250           72         2538
 MSBuild                 8          597          485           88           24
 OCaml                  89        11140         5997         3210         1933
 Objective-C          1721       111733        62368        30723        18642
 Objective-C++         496        37842        24784         6426         6632
 Pascal                 10          316           54          228           34
 Perl                   22         9025         5851         1612         1562
 Protocol Buffers        2          173          118           31           24
 Python               1673       237900       172805        24597        40498
 R                       1           15            7            5            3
 RPM Specfile            1          469          390            0           79
 ReStructuredText     1220       219333       219333            0            0
 Ruby                    1          125           89           23           13
 Rust                19032      1672465      1202002       276415       194048
 Scala                   6           54           54            0            0
 Shell                 246        65387        48964         9122         7301
 SVG                    53         5019         4661          358            0
 Swift                   2           23           17            0            6
 SWIG                   69        10949         7683          512         2754
 TeX                     6         3374         2992           22          360
 Plain Text           1506       517261       517261            0            0
 TOML                  797         8688         7335          179         1174
 TypeScript             25         3784         2906          345          533
 Vim Script             12          593          484           41           68
 Visual Studio Sol|      2           47           47            0            0
 XSL                     3          278          226           14           38
 XML                    51       135907       134752           18         1137
 YAML                  747        73902        59039        12268         2595
-------------------------------------------------------------------------------
 Total               99359     17289959     10993906      4310758      1985295
-------------------------------------------------------------------------------

@mark-i-m
Copy link
Member Author

mark-i-m commented Aug 2, 2020

@jyn514 Friendly ping :) It would be nice to merge this soon.

jyn514
jyn514 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@mark-i-m
Typo
5145608 
Co-authored-by: Joshua Nelson <[email protected]>
@mark-i-m mark-i-m merged commit cec6add into rust-lang:master Aug 3, 2020
@mark-i-m mark-i-m deleted the update-source-ch branch August 3, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrissimpkins chrissimpkins chrissimpkins left review comments

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes after std move to library
3 participants
@mark-i-m @chrissimpkins @jyn514