Skip to content

document #[cfg(bootstrap)] in dependencies #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2025
Merged

document #[cfg(bootstrap)] in dependencies #2346

merged 1 commit into from
Apr 19, 2025

Conversation

folkertdev
Copy link
Contributor

jieyouxu
jieyouxu approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good except for a chapter name nit

@jieyouxu jieyouxu added S-waiting-on-author Status: this PR is waiting for additional action by the OP T-bootstrap Relevant to bootstrap team labels Apr 19, 2025
@folkertdev folkertdev force-pushed the bootstrap-in-dependencies branch from c109950 to 4aa47cd Compare April 19, 2025 14:09
jieyouxu
jieyouxu approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu jieyouxu merged commit 3587bad into rust-lang:master Apr 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: this PR is waiting for additional action by the OP T-bootstrap Relevant to bootstrap team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@folkertdev @jieyouxu