compiletest: document {ignore,only}-{$target_triple,$target_arch} impl limitation
#2319
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
computed based on all the builtin target specs,
That is not correct. My issue is all about the fact that there are builtin targets that are not recognized by compiletest.
|
|
Also, what about OS and "env"? I assume those have the same problem? Do any other directives also have that problem? Someone who knows compiletest should ensure this list of caveats is complete.
|
|
Let me see if I can adjust the impl so that this caveat is no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @RalfJung
Closes rust-lang/rust#139516.