Rename config.toml to bootstrap.toml #2255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Shourya742 FWIW, you can coalesce this change into the r-l/r PR because they certainly make sense together. Usually we would ask to file the change separately if the r-d-g changes isn't accompanied by a r-l/r side change as well. |
Shourya742
force-pushed
the
2025-02-15-rename-config-toml-to-bootstrap-toml
branch
from
c0413b4 to
51260b3
Compare
Contributor
Author
Makes sense. I was wondering about that too, but I didn’t know how these kinds of workflows work here. Closing this PR, in the favour of PR on r-l/r |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both Bootstrap and Cargo uses same name as their configuration file, which can be confusing. This PR is based on a discussion to rename
config.tomltobootstrap.tomlfor Bootstrap. It is part of issue rust-lang/rust#126875.