Skip to content

Update chalk overview #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 2, 2018
Merged

Update chalk overview #223

merged 6 commits into from
Nov 2, 2018

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Oct 30, 2018

@tmandry tmandry mentioned this pull request Oct 30, 2018
Closed
mark-i-m
mark-i-m approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Thanks! I will wait for the others before merging.

tmandry
tmandry commented Nov 1, 2018
View reviewed changes
src/traits/chalk-overview.md

## Solver
The main kind of tests in chalk are **goal tests**. They contain a program,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this name up, but it seemed reasonable to me!

nikomatsakis
nikomatsakis approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good!

@nikomatsakis nikomatsakis merged commit 9fe13e7 into rust-lang:master Nov 2, 2018
@tmandry tmandry deleted the improve-chalk-overview branch November 2, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

@scalexm scalexm scalexm approved these changes

@mark-i-m mark-i-m mark-i-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmandry @nikomatsakis @scalexm @mark-i-m