Traits chapter cleanup #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found the layout to be a bit inconsistent before. This groups anything that touches logic rules under "Lowering to logic". This might be crowding too many things under that section, but it makes more sense to me overall.
mark-i-m
approved these changes
Oct 26, 2018
scalexm
reviewed
Oct 26, 2018
src/SUMMARY.md
Outdated
| @@ -38,12 +38,12 @@ | |||
| - [Goals and clauses](./traits/goals-and-clauses.md) | |||
| - [Equality and associated types](./traits/associated-types.md) | |||
| - [Implied bounds](./traits/implied-bounds.md) | |||
| - [Well-formedness checking](./traits/wf.md) | |||
There was a problem hiding this comment.
Could you put this chapter just after "lowering rules"? It's intended to be a "complete reference" chapter and I think it's better for this one to read it after being comfortable with the full set of lowering rules.
This was also intended to be a reference chapter, according to @scalexm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a small reorganization of the traits (new-style) chapter. IMO it makes sense to group the logic things together. Before, canonicalized queries were kind of in the middle of all the "logic" topics.
Here's what the chapter sidebar looks like now:
I also did some fly-by additions, and edits to break up the text. The edits make the text easier to scan/read by my eye, but this is extremely subjective, so let me know if anyone has objections.
This work is part of rust-lang/rust#55100.