Skip to content

Commit bd8eeff

Browse files
ChrisDentontshepang
authored andcommitted
Remove --bless from pre-push hook suggestion
According to rust-lang/rust@8873e33 > Running with --bless causes the push to succeed if there are fixable formatting changes, but the changes don't make it into the push. > > We should have the user rerun with --bless (or x.py fmt) and commit the changes themselves (they might want to amend a particular commit, for instance).
1 parent 7f426da commit bd8eeff

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/building/suggested.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ to make your life easier.
88
CI will automatically fail your build if it doesn't pass `tidy`, our
99
internal tool for ensuring code quality. If you'd like, you can install a
1010
[Git hook](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks)
11-
that will automatically run `./x.py test tidy --bless` on each push, to ensure
12-
your code is up to par. If you decide later that this behavior is
11+
that will automatically run `./x.py test tidy` on each push, to ensure
12+
your code is up to par. If the hook fails then run `./x.py test tidy --bless`
13+
and commit the changes. If you decide later that the pre-push behavior is
1314
undesirable, you can delete the `pre-push` file in `.git/hooks`.
1415

1516
A prebuilt git hook lives at [`src/etc/pre-push.sh`](https://github.com/rust-lang/rust/blob/master/src/etc/pre-push.sh) which can be copied into your `.git/hooks` folder as `pre-push` (without the `.sh` extension!).

0 commit comments

Comments
 (0)