Skip to content

Commit 7f426da

Browse files
ehusstshepang
authored andcommittedOct 27, 2022
Update for highfive transition.
1 parent 51a37ad commit 7f426da

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed
 

‎src/compiler-team.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,20 +111,22 @@ The guidelines for reviewers are as follows:
111111

112112
[Code of Conduct]: https://www.rust-lang.org/policies/code-of-conduct
113113

114-
### high-five
114+
### Reviewer rotation
115115

116-
Once you have r+ rights, you can also be added to the [high-five][hi5]
117-
rotation. high-five is the bot that assigns incoming PRs to
118-
reviewers. If you are added, you will be randomly selected to review
116+
Once you have r+ rights, you can also be added to the [reviewer rotation].
117+
[triagebot] is the bot that [automatically assigns] incoming PRs to reviewers.
118+
If you are added, you will be randomly selected to review
119119
PRs. If you find you are assigned a PR that you don't feel comfortable
120120
reviewing, you can also leave a comment like `r? @so-and-so` to assign
121121
to someone else — if you don't know who to request, just write `r?
122122
@nikomatsakis for reassignment` and @nikomatsakis will pick someone
123123
for you.
124124

125-
[hi5]: https://github.com/rust-highfive
125+
[reviewer rotation]: https://github.com/rust-lang/rust/blob/36285c5de8915ecc00d91ae0baa79a87ed5858d5/triagebot.toml#L528-L577
126+
[triagebot]: https://github.com/rust-lang/triagebot/
127+
[automatically assigns]: https://github.com/rust-lang/triagebot/wiki/Assignment
126128

127-
Getting on the high-five list is much appreciated as it lowers the
129+
Getting on the reviewer rotation is much appreciated as it lowers the
128130
review burden for all of us! However, if you don't have time to give
129131
people timely feedback on their PRs, it may be better that you don't
130132
get on the list.

‎src/contributing.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ when contributing to Rust under [the git section](./git.md).
7373
### r?
7474

7575
All pull requests are reviewed by another person. We have a bot,
76-
[@rust-highfive][rust-highfive], that will automatically assign a random person
76+
[@rustbot], that will automatically assign a random person
7777
to review your request based on which files you changed.
7878

7979
If you want to request that a specific person reviews your pull request, you
@@ -82,7 +82,7 @@ if you want to ask a review to @awesome-reviewer, add
8282

8383
r? @awesome-reviewer
8484

85-
to the end of the pull request description, and [@rust-highfive][rust-highfive] will assign
85+
to the end of the pull request description, and [@rustbot] will assign
8686
them instead of a random person. This is entirely optional.
8787

8888
You can also assign a random reviewer from a specific team by writing `r? rust-lang/groupname`.
@@ -91,8 +91,10 @@ team by adding:
9191

9292
r? rust-lang/diagnostics
9393

94-
For a full list of possible `groupname` check the `groups` section at the
95-
[rust highfive config file](https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json).
94+
For a full list of possible `groupname` check the `adhoc_groups` section at the
95+
[triagebot.toml config file](https://github.com/rust-lang/rust/blob/master/triagebot.toml)
96+
or the list of teams in the [rust-lang teams
97+
database](https://github.com/rust-lang/team/tree/master/teams).
9698

9799
### CI
98100

@@ -133,7 +135,7 @@ Changes that are rolled up are tested and merged alongside other PRs, to
133135
speed the process up. Typically only small changes that are expected not to conflict
134136
with one another are marked as "always roll up".
135137

136-
[rust-highfive]: https://github.com/rust-highfive
138+
[@rustbot]: https://github.com/rustbot
137139
[@bors]: https://github.com/bors
138140
[merge-queue]: https://bors.rust-lang.org/queue/rust
139141

‎src/getting-started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ highlights, but there are a lot more details, which we will link to below.
156156

157157
### Code Review
158158

159-
When you open a PR on the `rust-lang/rust` repo, a bot called `@rust-highfive` will
159+
When you open a PR on the `rust-lang/rust` repo, a bot called `@rustbot` will
160160
automatically assign a reviewer to the PR based on which files you changed.
161161
The reviewer is the person that will approve the PR to be tested and merged.
162162
If you want a specific reviewer (e.g. a team member you've been working with),

0 commit comments

Comments
 (0)
Please sign in to comment.