v0: add missing matching pop_depth for push_depth in skip_*.
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the problem I mentioned in #49 (comment).
The newly added (procedural) test fails before the changes I made, and passes afterwards.
AFAICT the symbols that it originally failed on come from Cargo (compiled with the
v0mangling enabled) - oncev0becomes the default, it might be worthwhile to setup some CI automation putting all_R[A-Z].*symbols that can be found in executables/.sos in~/.rustup/toolchains/*through the demangler, and checking that they demangle successfully.