Add support for sysroot --extern flag
#96061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This adds `sysroot` to the set of extern flags: `--extern sysroot:core=/path/to/core/libcore.rlib`. The primary effect of this flag is to suppress `unused-crate-dependencies` warnings relating to the crate. It's used for build environments where it's desirable for the build system to explicitly specify dependencies on sysroot crates rather than letting rustc find them implicitly. In such cases, these dependencies are likely to be added unconditionally, so there's no way that a user could act on an unused dependency warning.
|
I'm going to go with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
sysrootto the set of extern flags:--extern sysroot:core=/path/to/core/libcore.rlib.The primary effect of this flag is to suppress
unused-crate-dependencieswarnings relating to the crate.
It's used for build environments where it's desirable for the build
system to explicitly specify dependencies on sysroot crates rather than
letting rustc find them implicitly. In such cases, these dependencies
are likely to be added unconditionally, so there's no way that a user
could act on an unused dependency warning.
Alternatively, I'd be fine with making this flag more explicitly about
suppressing the warning - e.g.
nounused.